← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1177570] Re: Hyper-V tests can be refactored to avoid multiple mox.VerifyAll() calls

 

Tests have been refactored during Kilo and Liberty. Final patch that
merged in Liberty: https://review.openstack.org/#/c/139798/

No longer valid.

** Changed in: nova
       Status: Triaged => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1177570

Title:
  Hyper-V tests can be refactored to avoid multiple mox.VerifyAll()
  calls

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  The Hyper-V tests, specifically test_hypervap.py are currently using
  the mox framework for all the tests.

  As a result, it's possible to move the mox.VerifyAll() call from the
  single tests to tearDown().

  The advantages are:

  1) Less code bloathing due to duplicated VerifyAll() calls at 
     the end of each individual test

  2) Ensure that VerifyAll() is called in cases in which the developer might
     forget about adding it at the end of the test

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1177570/+subscriptions