yahoo-eng-team team mailing list archive

[OpenStack Infra <1522329@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/252836
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=66157aaeadc23d2183dae9046516abad0bcb81d5
Submitter: Jenkins
Branch:    master

commit 66157aaeadc23d2183dae9046516abad0bcb81d5
Author: Kevin_Zheng <zhengzhenyu@xxxxxxxxxx>
Date:   Thu Dec 3 17:18:05 2015 +0800

    Check 'destination_type' instead of 'source_type' in _check_and_transform_bdm
    
    In compute.api._check_and_transform_bdm() we have a logic to
    avoid boot instances with both image-ref and a volume named
    as 'vda' is supplied. Currently, we check the bdm's 'source_type',
    but infact we should check its' 'destination_type' as this
    shows it is a cinder volume.
    
    Change-Id: I1fe2cf7c6655e0e0c61371c6d7379ecfc7071cec
    Closes-Bug: #1522329


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1522329

Title:
  Check 'destination_type' instead of 'source_type' when boot instance
  by image and a volume with name 'vda'

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n796 , we have a logic to identify
  whether the instance is boot using image and also a volume named 'vda'. But we use 'source_type' to identify.
  We should use 'destination_type' = 'volume' as the identifier, as this will actually identify that a cinder volume 
  will be added as 'vda'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1522329/+subscriptions