yahoo-eng-team team mailing list archive

[Andres Rodriguez <andreserl@xxxxxxxxxxxxx>]

Public bug reported:

Cloud-init status messages that are send to MAAS provide a SUCCESS/FAIL
results for the different modules that cloud-init runs. As such, if a
module failed, MAAS captures that FAIL message and acts upon on it; for
example, it marks a machine Failed Deployment.

That being said, when using a MAAS data source/endpoint, there are some
cloud-init modules for which a failure is not critical; meaning that
cloud-init won't stop working or cause a deployment failure if the
module has failed. However, this doesn't reflect in the messaging. Even
if it is not a critical module, cloud-init will continue to send a FAIL
message to MAAS, which causes MAAS to mark a machine Failed Deployment.

As such, cloud-init shouldn't be tell MAAS that a module run has FAILED
if it is not critical to a MAAS deployment (that will cause a machine to
FAIL). In turn, cloud-init should be sending:

A different 'result' i.e. SUCCESS/FAIL/WARNING (or FAILCONTINUE)

As an example, the info sent to MAAS is:

            "event_type": "finish",
            "origin": "curtin",
            "description": "Finished XYZ",
            "name": "cmd-install",
            "result": "FAIL",

** Affects: cloud-init
     Importance: Undecided
         Status: New

** Description changed:

  Cloud-init status messages that are send to MAAS provide a SUCCESS/FAIL
  results for the different modules that cloud-init runs. As such, if a
  module failed, MAAS captures that FAIL message and acts upon on it; for
  example, it marks a machine Failed Deployment.
  
  That being said, when using a MAAS data source/endpoint, there are some
  cloud-init modules for which a failure is not critical; meaning that
  cloud-init won't stop working or cause a deployment failure if the
  module has failed. However, this doesn't reflect in the messaging. Even
  if it is not a critical module, cloud-init will continue to send a FAIL
  message to MAAS, which causes MAAS to mark a machine Failed Deployment.
  
  As such, cloud-init shouldn't be tell MAAS that a module run has FAILED
  if it is not critical to a MAAS deployment (that will cause a machine to
  FAIL). In turn, cloud-init should be sending:
  
- 1. A different 'result' i.e. SUCCESS/FAIL/WARNING (or FAILCONTINUE)
- or
- 2. More information that would allow to determine that the FAIL is not critical for MAAS, and regardless of the result being a FAIL MAAS should continue.
+ A different 'result' i.e. SUCCESS/FAIL/WARNING (or FAILCONTINUE)
  
  As an example, the info sent to MAAS is:
  
-             "event_type": "finish",
-             "origin": "curtin",
-             "description": "Finished XYZ",
-             "name": "cmd-install",
-             "result": "FAIL",
+             "event_type": "finish",
+             "origin": "curtin",
+             "description": "Finished XYZ",
+             "name": "cmd-install",
+             "result": "FAIL",

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1555238

Title:
  cloud-init FAIL status message doesn't differentiate between a
  critical failure vs

Status in cloud-init:
  New

Bug description:
  Cloud-init status messages that are send to MAAS provide a
  SUCCESS/FAIL results for the different modules that cloud-init runs.
  As such, if a module failed, MAAS captures that FAIL message and acts
  upon on it; for example, it marks a machine Failed Deployment.

  That being said, when using a MAAS data source/endpoint, there are
  some cloud-init modules for which a failure is not critical; meaning
  that cloud-init won't stop working or cause a deployment failure if
  the module has failed. However, this doesn't reflect in the messaging.
  Even if it is not a critical module, cloud-init will continue to send
  a FAIL message to MAAS, which causes MAAS to mark a machine Failed
  Deployment.

  As such, cloud-init shouldn't be tell MAAS that a module run has
  FAILED if it is not critical to a MAAS deployment (that will cause a
  machine to FAIL). In turn, cloud-init should be sending:

  A different 'result' i.e. SUCCESS/FAIL/WARNING (or FAILCONTINUE)

  As an example, the info sent to MAAS is:

              "event_type": "finish",
              "origin": "curtin",
              "description": "Finished XYZ",
              "name": "cmd-install",
              "result": "FAIL",

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1555238/+subscriptions