← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1518321] Re: cannot set injected_files in build_instance pre hook

 

Reviewed:  https://review.openstack.org/248662
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=be4220b37df42d4f99b5f5b8c18245a315228a8a
Submitter: Jenkins
Branch:    master

commit be4220b37df42d4f99b5f5b8c18245a315228a8a
Author: Juan Antonio Osorio Robles <jaosorior@xxxxxxxxxx>
Date:   Mon Nov 23 14:24:36 2015 +0200

    Set personality/injected_files to empty list if not specified
    
    Previously, in the legacy_v2 controller, a "create" would pass an empty
    list as a default for the injected files to the compute API. This
    behavior has changed, and now, if no personality is specified, the
    injected_files parameter ends up as None.
    
    An empty list coming from the controller enabled us to inject files
    through the hook mechanism. So, having this behavior changed,
    breaks the functionality that was available through this, since we
    now aren't able to use that parameter effectively.
    
    Change-Id: Iac02c4ba23381889c36d897451b3e89756a75d4d
    Co-Authored-By: Rob Crittenden <rcritten@xxxxxxxxxx>
    Closes-Bug: #1518321


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1518321

Title:
  cannot set injected_files in build_instance pre hook

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  http://lists.openstack.org/pipermail/openstack-
  dev/2015-November/079904.html

  I have some code that uses the build_instance pre hook to set 
  injected_files in the new instance.  With the kilo code, the argv[7] was 
  passed as [] - so I could append/extend this value to add more 
  injected_files.  With the latest code, this is passed as None, so I 
  can't set it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1518321/+subscriptions


References