← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1555429] Re: Theme switcher doesn't retain location on some pages

 

Reviewed:  https://review.openstack.org/290967
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=900fe7dfd99e478e95dc219cd86756060c39986e
Submitter: Jenkins
Branch:    master

commit 900fe7dfd99e478e95dc219cd86756060c39986e
Author: Richard Jones <r1chardj0n3s@xxxxxxxxx>
Date:   Thu Mar 10 14:54:14 2016 +1100

    Remove default event handler from theme switch links
    
    On Chrome the default <a> event handler was firing after reload()
    resulting in a change of location.
    
    This was particularly noticeable on the new angular Swift UI.
    
    Change-Id: I5b644f3b899a5a8c598ceae7cdb76a1e9fd89ebf
    Closes-Bug: 1555429


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1555429

Title:
  Theme switcher doesn't retain location on some pages

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The theme switcher doesn't stay on the same page after theme switch in
  some cases.

  It turns out that on Chrome (but not Firefox) the <a> href event
  handler was firing after the reload, sending us off to the /#
  location.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1555429/+subscriptions


References