← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1554087] Re: when update row with the multi_select set false tables.js gives error

 

Reviewed:  https://review.openstack.org/291345
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c9a229ed5b0628f858538032563169811cee35c7
Submitter: Jenkins
Branch:    master

commit c9a229ed5b0628f858538032563169811cee35c7
Author: Kirill Zaitsev <kzaitsev@xxxxxxxxxxxx>
Date:   Thu Mar 10 21:01:51 2016 +0300

    Ensure there is checkbox before accessing it's properties
    
    Currently js code, that updates ajax rows in horizon tables expects each
    row to have a checkbox. Otherwise it throws an error. This commit adds a
    check, that ensures, that there is a multi-select checkbox before
    accessing it's properties, to allow non-multi-select tables have ajax
    rows.
    
    Change-Id: I665df75fe09da149c5401620df188f738845a016
    Closes-Bug: #1554087


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1554087

Title:
  when update row with the multi_select set false tables.js gives error

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  We set multi_select=false, and the table have update row, then the horizon give the error:
  TypeError: $row.find(...)[0] is undefined

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1554087/+subscriptions


References