yahoo-eng-team team mailing list archive

[Steve Martinelli <stevemar@xxxxxxxxxx>]

Dave, if something is fixed simply mark is as `Fix Released`.

See http://lists.openstack.org/pipermail/openstack-
dev/2015-November/078301.html

"As part of this rollout, I will also be updating the settings for
the gerrit hook script so that when a patch with "Closes-Bug" in
the commit message is merged the bug will be marked as "Fix Released"
instead of "Fix Committeed" (since "Fix Committed" is not a closed
state)."

** Changed in: keystone
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1396650

Title:
  Duplicated tests for Catalog

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  About testing the catalog backends (KVS, SQL and Templated). Now, we
  have to different test files to do the same things.

  keystone/tests/test_backend.py -> Which has a lot of test related with Identity, Policy, Token, ... and Catalog
  keystone/tests/test_catalog.py   -> Which has a few tests only for the catalog backends. Those test are not enough to test everything in the catalog.

  In my opinion is not a good idea to have different test files for the
  same purpose because some people could implement test only in one of
  the test files, not in both. Also, it is a pain to maintain.

  I propose to remove all the test that we have right now in
  keystone/tests/test_catalog.py (please forget class
  V2CatalogTestCase(rest.RestfulTestCase)) and move the tests related
  with Catalog that, right now, we have in
  keystone/tests/test_backend.py to keystone/tests/test_catalog.py

  What do you think?

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1396650/+subscriptions