yahoo-eng-team team mailing list archive

[OpenStack Infra <1532258@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/290946
Committed: https://git.openstack.org/cgit/openstack/tap-as-a-service/commit/?id=dff4505697d3bdb9a54bf4cde661e5e1b8cf6983
Submitter: Jenkins
Branch:    master

commit dff4505697d3bdb9a54bf4cde661e5e1b8cf6983
Author: reedip <reedip.banerjee@xxxxxxxxxxxxxxxxxx>
Date:   Thu Mar 10 11:11:33 2016 +0900

    Fix Gate tests
    
    Seems [1] and an unnecessay inheritance may be the
    cuplrit for the newly occurring failures [2] of
    Python2.7 and Python3.4 gate jobs for tap-as-a-service.
    
    [1]: https://bugs.launchpad.net/python-neutronclient/+bug/1532258
    [2]: http://paste.openstack.org/show/489947/
    
    Closes-Bug: #1532258
    Change-Id: I1b97fe8541c1c1325aaad739a30e5989c1fd806a


** Changed in: tap-as-a-service
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1532258

Title:
  neutronclient commands do not follow cliff command guideline

Status in neutron:
  Fix Released
Status in python-neutronclient:
  Fix Released
Status in tap-as-a-service:
  Fix Released

Bug description:
  The docstring of cliff.command.Command says  that developers
  implementing commands should override take_action instead of run [1].

  neutornclient DeleteCommand and UpdateCommand override run().
  take_action() should be used.

  In addition, neutronclient.common.command.OpenStackCommand provides an
  extra and meaningless layer and interface get_data(). get_data()
  provides no addition value. take_action() should be used.
  CreateCommand, ShowCommand and ListCommand are affected.

  [1]
  https://github.com/openstack/cliff/blob/master/cliff/command.py#L39-L52

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1532258/+subscriptions