yahoo-eng-team team mailing list archive

[OpenStack Infra <1541560@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/277597
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e0b3665280a136bec4ccc70b4ca13fc59319e471
Submitter: Jenkins
Branch:    master

commit e0b3665280a136bec4ccc70b4ca13fc59319e471
Author: James Anziano <janzian@xxxxxxxxxx>
Date:   Mon Feb 8 22:35:42 2016 +0000

    Stops update_network handling updates it shouldn't
    
    Currently update_network() attempts to update the network table with
    any parameters that belong to a network, even if those attributes are
    stored in a separate database table. This was causing certain update
    commands to fail (such as updating dns_domain). The actual update to
    dns_domain is handled by extensions called by the ml2 plugin, but this
    function was also trying to process it and causing an error.
    
    This patch ensures the network variable is only updated with
    attributes that are actually in the networks table by filtering out
    any parameters that don't match fields in the Network class model.
    
    Change-Id: I54a736d91de52dda85c559b9e6103199f914abdf
    Closes-bug: 1541560


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1541560

Title:
  Updating a network can result in an internal server error

Status in neutron:
  Fix Released

Bug description:
  When updating a network with an attribute not technically in the
  network database table, but still a valid attribute (i.e. dns_domain,
  which is used by network but stored in a separate table), neutron
  attempts to update the network table with that field and throws an
  exception.

  To reproduce:
  neutron net-update my_network --dns_domain=my-domain.org.
  which results in:
  Request Failed: internal server error while processing your request.

  Openstack version: DevStack all-in-one built from master
  Ubuntu 14.04, kernel 3.13.0-24-generic
  Perceived severity: medium

  Logs of the traceback from q-svc:
  http://paste.openstack.org/show/485883/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1541560/+subscriptions