← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1555602] Re: Resource tracker _get_instance_type stashed_flavor logic is wrong

 

Reviewed:  https://review.openstack.org/291138
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b12106467d4f1ae906bef3ef87858f2b6e0f908e
Submitter: Jenkins
Branch:    master

commit b12106467d4f1ae906bef3ef87858f2b6e0f908e
Author: Sean Dague <sean@xxxxxxxxx>
Date:   Thu Mar 10 07:19:26 2016 -0500

    Make tuple actually a tuple
    
    When reviewing an unrelated patch I saw this line of code which is
    definitely wrong. This looks like a copy / paste error from
    Ie74939e543155bc42705b28e1b44d943ef54ebdc.
    
    Change-Id: Ia3aca2df622713dee5cde091c4d48baa803c678f
    Closes-Bug: #1555602


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1555602

Title:
  Resource tracker _get_instance_type stashed_flavor logic is wrong

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The logic for _get_instance_type in resource tracker includes:

  migration.migration_type in ('resize') which is the same as

  migration.migration_type in 'resize' 
  migration.migration_type in ('r', 'e', 's', 'i', 'z', 'e')

  Which looks like it is a copy / paste error from the initial commit
  here - https://review.openstack.org/#/c/226411/

  This should be a tuple and not a string.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1555602/+subscriptions


References