← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1557495] [NEW] Possible race conditions when changing image status in v2

 

Public bug reported:

Currently Glance architecture (domain model) is affected by possible
race conditions during image status transition. To eliminate this there
was introduced a parameter called 'from_state' in 'save' method for
ImageRepo. Unfortunately it only checks if transition happened from
'saving' to 'active':
https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L117

Other cases are still not fixed and it leads to the fact that admin can
reactivate deleted image and it will have status 'active'. Also Glance
rewrites the status even if it didn't change. To fix it it's suggested
to use 'from_state' parameters in other places, where race conditions
may happen.

** Affects: glance
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1557495

Title:
  Possible race conditions when changing image status in v2

Status in Glance:
  New

Bug description:
  Currently Glance architecture (domain model) is affected by possible
  race conditions during image status transition. To eliminate this
  there was introduced a parameter called 'from_state' in 'save' method
  for ImageRepo. Unfortunately it only checks if transition happened
  from 'saving' to 'active':
  https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L117

  Other cases are still not fixed and it leads to the fact that admin
  can reactivate deleted image and it will have status 'active'. Also
  Glance rewrites the status even if it didn't change. To fix it it's
  suggested to use 'from_state' parameters in other places, where race
  conditions may happen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1557495/+subscriptions


Follow ups