← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1557785] Re: auto_allocated_topology migration generates inconsistent external networks with PostgreSQL

 

Reviewed:  https://review.openstack.org/293171
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d4aa8c5ea97cf0c8e52bc0a2cf635fc322ea8f19
Submitter: Jenkins
Branch:    master

commit d4aa8c5ea97cf0c8e52bc0a2cf635fc322ea8f19
Author: Cedric Brandily <zzelle@xxxxxxxxx>
Date:   Tue Mar 15 23:04:05 2016 +0100

    Fix auto_allocated_topology migration with PostgreSQL
    
    auto_allocated_topology migration[1] adds the column nullable boolean
    column is_default to externalnetworks table. PostgreSQL sets is_default
    to NULL as no server_default value is provided.
    
    It implies inconsistencies with PostgreSQL as neutron-server returns
    for non-default external-networks:
    * is_default == None for external-networks migrated from Liberty,
    * is_default == False for external-networks created with Mitaka.
    
    This change alters is_default column in externalnetworks table into a
    non-nullable column with a server_default value (False).
    
    [1] neutron/db/migration/alembic_migrations/versions/mitaka/expand/i\
    19f26505c74f_auto_allocated_topology.py
    
    Closes-Bug: #1557785
    Change-Id: I004a76237fe8d927a1d45dab4fdfefaf1af6de96


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1557785

Title:
  auto_allocated_topology migration generates inconsistent external
  networks with PostgreSQL

Status in neutron:
  Fix Released

Bug description:
  auto_allocated_topology migration[1] adds the column nullable boolean column is_default to externalnetworks table. MySQL sets is_default to False during the migration (wtf?) where PostgreSQL sets is_default to NULL. It implies Neutron with PostgreSQL returns is_default == null for external-networks migrated from Liberty to Mitaka and is_default == 
  False for non is_default external-networks created after Mitaka migration.

  
  [1] neutron/db/migration/alembic_migrations/versions/mitaka/expand/19f26505c74f_auto_allocated_topology.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1557785/+subscriptions


References