← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1557868] Re: the size of close icon are different between delete confirm dialog and other modal dialog .

 

Reviewed:  https://review.openstack.org/293252
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f88598f8137b683613d7803a1992d213873c8915
Submitter: Jenkins
Branch:    master

commit f88598f8137b683613d7803a1992d213873c8915
Author: Kenji Ishii <ken-ishii@xxxxxxxxxxxxx>
Date:   Wed Mar 16 14:27:24 2016 +0900

    Fix the size of the close icon on delete confirm dialog
    
    Change-Id: I35682659fd88d08eff1e65d645279b6b737438a7
    Closes-bug: #1557868


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1557868

Title:
  the size of close icon are different between delete confirm dialog and
  other modal dialog .

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  At the moment, the code is below and the size of this icon are different between delete confirm dialog and other modal dialog .
          <a class='close' data-dismiss='modal'>&times;</a>

  We should use the code below.
            <a href="#" class="close" data-dismiss="modal">
              <span class="fa fa-times"></span>
            </a>

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1557868/+subscriptions


References