← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1555830] Re: 'service provider show' returns a service provider when queried with wrong sp_id

 

Reviewed:  https://review.openstack.org/291584
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=cecf6048f2018e7cea864e3a6ff18b9088ac4254
Submitter: Jenkins
Branch:    master

commit cecf6048f2018e7cea864e3a6ff18b9088ac4254
Author: Steve Martinelli <stevemar@xxxxxxxxxx>
Date:   Fri Mar 11 02:45:53 2016 -0500

    Support `id` and `enabled` attributes when listing service providers
    
    list SPs currently doesn't support to filter records by any
    attributes, but this is used somewhere, such as OpenStack
    Client using `name` to filter the record.
    
    SP doesn't has `name` attribute but has `id`, `enabled`
    attributes instead.
    
    This patch enables the filtering of Service Provider based
    on `id`, `enabled` attributes so that OpenStack Client or the
    CURL query can benefit from it.
    
    based off of: Ib672ba759d26bdd0eecd48451994b3451fb8648a
    
    Closes-Bug: 1555830
    
    Change-Id: Icdecaa44415786397ee8bb22de16d25cb8fe603a


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1555830

Title:
  'service provider show' returns a service provider when queried with
  wrong sp_id

Status in OpenStack Identity (keystone):
  Fix Released
Status in python-openstackclient:
  In Progress

Bug description:
  ubuntu@k2k-idp3:~$ openstack service provider list
  +-------------+---------+-------------+---------------------------------------------------------------------------------------------------+
  | ID          | Enabled | Description | Auth URL                                                                                          |
  +-------------+---------+-------------+---------------------------------------------------------------------------------------------------+
  | keystone-sp | True    | None        | http://xxx.xxx.xxx.xxx:35357/v3/OS-FEDERATION/identity_providers/keystone-idp/protocols/saml2/auth |
  +-------------+---------+-------------+---------------------------------------------------------------------------------------------------+
  ubuntu@k2k-idp3:~$ openstack service provider show nonexistent
  +--------------------+---------------------------------------------------------------------------------------------------+
  | Field              | Value                                                                                             |
  +--------------------+---------------------------------------------------------------------------------------------------+
  | auth_url           | http://xxx.xxx.xxx.xxx:35357/v3/OS-FEDERATION/identity_providers/keystone-idp/protocols/saml2/auth |
  | description        | None                                                                                              |
  | enabled            | True                                                                                              |
  | id                 | keystone-sp                                                                                       |
  | relay_state_prefix | ss:mem:                                                                                           |
  | sp_url             | http://xxx.xxx.xxx.xxx:5000/Shibboleth.sso/SAML2/ECP                                               |
  +--------------------+---------------------------------------------------------------------------------------------------+
  ubuntu@k2k-idp3:~$ pip show python-openstackclient
  ---
  Metadata-Version: 2.0
  Name: python-openstackclient
  Version: 2.2.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1555830/+subscriptions