yahoo-eng-team team mailing list archive

[OpenStack Infra <1555863@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/294317
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=83a2d36adcd328f56f47b3e1da0c57f430b1c5da
Submitter: Jenkins
Branch:    master

commit 83a2d36adcd328f56f47b3e1da0c57f430b1c5da
Author: Eddie Ramirez <eddie.ramirez@xxxxxxxxx>
Date:   Thu Mar 17 22:28:25 2016 +0000

    Bootstrap Theme Preview links to sections don't work Edit
    
    There's a bug indicating that the browser won't scroll to #element-id when
    clicking anchor links (href="#element-id"). We can fix this issue bypassing
    AngularJS router using target="_self". This fix works but Angular is still
    rewriting the the hash to "its style", another way to fix this could be to
    enable html5Mode and will allow us to use browser history.
    
    This commit also inserts an element (using :before pseudo-selector) with
    negative margin matching the navbar height, thus preventing h1 elements from
    being overlapped by the navbar (which is position:fixed).
    
    Change-Id: Ia51b385a8148440d86dd588918658f5454416d77
    Closes-bug: #1555863


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1555863

Title:
  Bootstrap Theme Preview links to sections don't work

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  At the top of the Bootstrap Theme Preview there is a list of all the
  elements drill into.

  Navbar
  Buttons
  Typograph
  Tables
  Forms
  ...

  Clicking on each one doesn't jump to the section. Anchor tags don't
  work. :\

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1555863/+subscriptions