yahoo-eng-team team mailing list archive

[OpenStack Infra <1558774@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/294460
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=85d638af455ae881ca45d2d390606ef1df5904b1
Submitter: Jenkins
Branch:    master

commit 85d638af455ae881ca45d2d390606ef1df5904b1
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Fri Mar 18 17:41:23 2016 +0900

    Accept icmpv6 as protocol of SG rule for backward compatibility
    
    The patch https://review.openstack.org/#/c/252155/ renamed
    'icmpv6' protocol to 'ipv6-icmp'.
    This leads to backward compatiblity of the security group API.
    This commit allows to specify 'icmpv6' as well.
    
    TODO(amotoki): The constant for 'icmpv6' will be moved to
    neutron-lib soon after Mitaka is shipped.
    
    Change-Id: I0d7e1cd9fc075902449c5eb5ef27069083ab95d4
    Closes-Bug: #1558774


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1558774

Title:
  backward-incompat change in security group API: icmpv6 is not
  supported for protocol in Mitaka

Status in neutron:
  Fix Released

Bug description:
  The patch https://review.openstack.org/#/c/252155/ adds various protocol names,
  but the change itself is backward incompatible.

  Previously we supported 'ipv6' for protocol to allow ICMPv6 specific type/code.
  In the new code, we no longer use 'ipv6' and we need to use a newly added protocol name.

  IMO it is better to keep the backward compatiblity.
  If we keep the new behavior, at least we MUST mention this backward-incompatible change in the release note.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1558774/+subscriptions