yahoo-eng-team team mailing list archive

[OpenStack Infra <1558306@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/293747
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=0067e2671d1c33e630dff947ac7090c370152225
Submitter: Jenkins
Branch:    master

commit 0067e2671d1c33e630dff947ac7090c370152225
Author: James Arendt <james.arendt@xxxxxx>
Date:   Thu Mar 10 20:27:08 2016 -0800

    VPNaaS returns 500 INTERNAL error with long names, descriptions
    
    Should be verifying length at REST boundary to return more
    reasonable 400 class user error, both because under user control
    and because more meaningful to the user error message.
    
    Closes-Bug: #1558306
    Change-Id: I44a64d841e61b4f7f6872124a8f6242c4c96cf44


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1558306

Title:
  VPNaaS returns 500 INTERNAL on long names

Status in neutron:
  Fix Released

Bug description:
  Current VPNaaS returns a 500 INTERNAL SERVER error when given long
  names or descriptions.

  Instead should give a 400 BAD REQUEST explaining user given value
  exceeds maximum threshold, like:

  neutron vpn-service-create router1 --name
  012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789

  Invalid input for name. Reason:
  '012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789'
  exceeds maximum length of 255.

  Applies to both names and descriptions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1558306/+subscriptions