← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1561022] Re: Server group policies are not honored during live migration

 

Reviewed:  https://review.openstack.org/296596
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=00efcf3a4171d270fc3a7b9b4a9230332aea81e6
Submitter: Jenkins
Branch:    master

commit 00efcf3a4171d270fc3a7b9b4a9230332aea81e6
Author: Pawel Koniszewski <pawel.koniszewski@xxxxxxxxx>
Date:   Wed Mar 23 18:44:10 2016 +0100

    Try to repopulate instance_group if it is None
    
    There are cases that we need to create new RequestSpect object and we
    pass None for instance_group argument. It might cause server group
    policies to be omitted during filtering phase. Therefore if
    instance_group is None we should try to repopulate instance_group
    basing on data that is in filter_properties.
    
    Change-Id: Id7e669e0a6db1ff1052c42006f1a141bdb8cdf29
    Closes-Bug: #1561022


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1561022

Title:
  Server group policies are not honored during live migration

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) mitaka series:
  In Progress

Bug description:
  Commit
  https://github.com/openstack/nova/commit/111a852e79f0d9e54228d8e2724dc4183f737397
  introduced regression that causes affinity/anti-affinity policies to
  be omitted while live migrating an instance.

  This is because we don't pass instance_group here:

  https://github.com/openstack/nova/blob/111a852e79f0d9e54228d8e2724dc4183f737397/nova/conductor/tasks/live_migrate.py#L183

  However, filters are expecting this information:

  https://github.com/openstack/nova/blob/111a852e79f0d9e54228d8e2724dc4183f737397/nova/scheduler/filters/affinity_filter.py#L86

  Basically we should pass instance group so that filters can read this
  information later.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1561022/+subscriptions


References