← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1517038] Re: API-based Domain config method could temporarily show partial update

 

Reviewed:  https://review.openstack.org/290223
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=8ce8c99023c797be6ea36c4d7a2889cf633bf279
Submitter: Jenkins
Branch:    master

commit 8ce8c99023c797be6ea36c4d7a2889cf633bf279
Author: Henry Nash <henryn@xxxxxxxxxxxxxxxxxx>
Date:   Tue Mar 8 22:25:35 2016 +0000

    Make modifications to domain config atomic
    
    Currently, since creating or updating a domain config is
    done as a sequence of option creates/updates, it is possible
    for other keystone threads/processes to see a partial update
    if the cache timeout occurs in the middle of such an update.
    
    This patch makes the creation/updating of a domain config
    atomic (by doing it all within a common sql session), hence
    avoiding this issue.
    
    This issue has not been reported in the field - and is extremely
    difficult to test, so we are relying on code inspection to
    convince ourselves we have solved this issue.
    
    Since the domain config API is still marked as experimental, we
    do not gurantee backward compatability for the driver. Hence,
    although this patch modifies the driver interface, it does not
    include a new versioned driver.
    
    Closes-bug: 1517038
    Change-Id: I16598051ca456cf1c036c412111426b4cd9241b8


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1517038

Title:
  API-based Domain config method could temporarily show partial update

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  When using the API-based domain config method, the options are not
  updated atomically. The result is that for a "cache update period",
  someone else reading the options (i.e. the processing of a user/group
  API call in another keystone process) might see a partial update.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1517038/+subscriptions


References