yahoo-eng-team team mailing list archive

[Aditya Vaja <wolverine.av@xxxxxxxxx>]

*** This bug is a duplicate of bug 1563028 ***
    https://bugs.launchpad.net/bugs/1563028

Public bug reported:

Hi,

I'm seeing unit test failures when I test locally after a fresh git
clone of neutron master. Most recent commit in git log: commit
f337a20a2fe7f9cb785d2e78856c1396bc087e65

$ ./run_tests.sh -V -f

log excerpt: http://paste.openstack.org/show/492384/

I update the requirements.txt to use 'Routes<2.0,>=1.12.3' and all the tests work fine.
I see there was a new release (v2.3 ) of Routes on 28th March 2016 [1], which seems to have caused the issue, specifically:
 - Concatenation fix when using submappers with path prefixes. Multiple submappers combined the path prefix inside the controller argument in non-obvious ways. The controller argument will now be properly carried through when using submappers. PR #28[2].

Should I submit this requirements.txt change as a patch or should we
pass the required two args as the patch? I can do the requirement.txt
change. For the latter, somebody who knows what goes on in the
extensions.py __init__() should take a look.

I assume this will also affect the stable branches, since the Routes
package versin in requirements.txt in previous versions was same as in
master.

--
Aditya

[1] https://routes.readthedocs.org/en/latest/changes.html#release-2-3-march-28-2016
[2] https://github.com/bbangert/routes/pull/28/files?diff=unified#diff-b54de741c3f86d76eb4bce4a223054aaL154

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: unittest

** Patch added: "diff of requirements.txt I made locally to make it work again."
   https://bugs.launchpad.net/bugs/1563621/+attachment/4616538/+files/routes_requirements.diff

** This bug has been marked a duplicate of bug 1563028
   Routes version 2.3 broke the way we register routes

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1563621

Title:
  unit test failures due to new release of Routes package (v2.3)

Status in neutron:
  New

Bug description:
  Hi,

  I'm seeing unit test failures when I test locally after a fresh git
  clone of neutron master. Most recent commit in git log: commit
  f337a20a2fe7f9cb785d2e78856c1396bc087e65

  $ ./run_tests.sh -V -f

  log excerpt: http://paste.openstack.org/show/492384/

  I update the requirements.txt to use 'Routes<2.0,>=1.12.3' and all the tests work fine.
  I see there was a new release (v2.3 ) of Routes on 28th March 2016 [1], which seems to have caused the issue, specifically:
   - Concatenation fix when using submappers with path prefixes. Multiple submappers combined the path prefix inside the controller argument in non-obvious ways. The controller argument will now be properly carried through when using submappers. PR #28[2].

  Should I submit this requirements.txt change as a patch or should we
  pass the required two args as the patch? I can do the requirement.txt
  change. For the latter, somebody who knows what goes on in the
  extensions.py __init__() should take a look.

  I assume this will also affect the stable branches, since the Routes
  package versin in requirements.txt in previous versions was same as in
  master.

  --
  Aditya

  [1] https://routes.readthedocs.org/en/latest/changes.html#release-2-3-march-28-2016
  [2] https://github.com/bbangert/routes/pull/28/files?diff=unified#diff-b54de741c3f86d76eb4bce4a223054aaL154

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1563621/+subscriptions