yahoo-eng-team team mailing list archive

[Wang Bo <bo.wang@xxxxxxxxxxxx>]

Public bug reported:

Ref:http://docs.openstack.org/developer/horizon/tutorials/plugin.html.
There are some configure settings for plugin development.

AUTO_DISCOVER_STATIC_FILES = True
ADD_JS_FILES = [ ]
ADD_SCSS_FILES = [ ]

Ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L123
if AUTO_DISCOVER_STATIC_FILES == True,  both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed.

But now only js files could be discovered, scss files are left. ref:
https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L79.
That result in we must add scss files of plugin into ADD_SCSS_FILES.
ref: https://github.com/openstack/magnum-
ui/blob/master/enabled/_50_project_containers_panelgroup.py#L34

IMO this is not what we want, both js and scss files should be
discovered automatically. And "ADD_JS_FILES" and "ADD_SCSS_FILES" are
used for specific files not in myplugin/static/.

** Affects: horizon
     Importance: Undecided
     Assignee: Wang Bo (chestack)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Wang Bo (chestack)

** Description changed:

  Ref:http://docs.openstack.org/developer/horizon/tutorials/plugin.html.
  There are some configure settings for plugin development.
  
  AUTO_DISCOVER_STATIC_FILES = True
  ADD_JS_FILES = [ ]
  ADD_SCSS_FILES = [ ]
  
  Ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L123
- if AUTO_DISCOVER_STATIC_FILES == True,  both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed. 
+ if AUTO_DISCOVER_STATIC_FILES == True,  both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed.
  
  But now only js files could be discovered, scss files are left. ref:
  https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L79.
  That result in we must add scss files of plugin into ADD_SCSS_FILES.
+ ref: https://github.com/openstack/magnum-
+ ui/blob/master/enabled/_50_project_containers_panelgroup.py#L34
+ 
+ IMO this is not what we want, both js and scss files should be
+ discovered automatically. And "ADD_JS_FILES" and "ADD_SCSS_FILES" are
+ used for specific files not in myplugin/static/.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1563654

Title:
  scss files can not be  automatically discovered

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Ref:http://docs.openstack.org/developer/horizon/tutorials/plugin.html.
  There are some configure settings for plugin development.

  AUTO_DISCOVER_STATIC_FILES = True
  ADD_JS_FILES = [ ]
  ADD_SCSS_FILES = [ ]

  Ref: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L123
  if AUTO_DISCOVER_STATIC_FILES == True,  both static resources including js files and scss files under myplugin/static/ should be discovered to be compressed.

  But now only js files could be discovered, scss files are left. ref:
  https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L79.
  That result in we must add scss files of plugin into ADD_SCSS_FILES.
  ref: https://github.com/openstack/magnum-
  ui/blob/master/enabled/_50_project_containers_panelgroup.py#L34

  IMO this is not what we want, both js and scss files should be
  discovered automatically. And "ADD_JS_FILES" and "ADD_SCSS_FILES" are
  used for specific files not in myplugin/static/.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1563654/+subscriptions