← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1558626] Re: [sriov] physical_device_mappings allows only one physnet for per nic

 

Reviewed:  https://review.openstack.org/294188
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=46ddaf4288a1cac44d8afc0525b4ecb3ae2186a3
Submitter: Jenkins
Branch:    master

commit 46ddaf4288a1cac44d8afc0525b4ecb3ae2186a3
Author: Vladimir Eremin <veremin@xxxxxxxxxxxx>
Date:   Thu Mar 17 19:32:29 2016 +0300

    Allow to use several nics for physnet with SR-IOV
    
    Accordind specs and docs, SRIOV_NIC.physical_device_mappings is not
    limited to be a 1-1 mapping between physnets and NICs. However,
    implementation requires this. This bugfix unlocks 1-M mappings, so one
    physnet could be managed by many NICs.
    
    * introduced unique_keys in neutron.utils.parse_mappings
    * SRIOV_NIC.physical_device_mappings is parsed as dict with lists as
      values with parse_mappings(..., unique_keys=False)
    
    DocImpact
    Change-Id: I07b8682fdfe8389a35893cc662b87c94a00bd4a5
    Closes-Bug: #1558626


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1558626

Title:
  [sriov] physical_device_mappings allows only one physnet for per nic

Status in neutron:
  Fix Released

Bug description:
  Mitaka, ML2, ml2_sriov.agent_required=True

  sriov_nic.physical_device_mappings is allowed to specify ony one NIC
  per physnet. If I try to specify two nics like following

  [sriov_nic]
  physical_device_mappings=physnet2:enp1s0f0,physnet2:enp1s0f1

  I've got next error on start

  2016-03-17 15:26:48.818 6832 INFO neutron.common.config [-] Logging enabled!
  2016-03-17 15:26:48.819 6832 INFO neutron.common.config [-] /usr/bin/neutron-sriov-nic-agent version 8.0.0.0b3
  2016-03-17 15:26:48.819 6832 DEBUG neutron.common.config [-] command line: /usr/bin/neutron-sriov-nic-agent --config-file=/etc/neutron/plugins/ml2/sriov_agent.ini --log-file=/var/log/neutron/neutron-sriov-agent.log --config-file=/etc/neutron/neutron.conf setup_logging /usr/lib/python2.7/dist-packages/neutron/common/config.py:266
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent [-] Failed on Agent configuration parse. Agent terminated!
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent Traceback (most recent call last):
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent   File "/usr/lib/python2.7/dist-packages/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py", line 436, in main
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent     config_parser.parse()
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent   File "/usr/lib/python2.7/dist-packages/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py", line 411, in parse
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent     cfg.CONF.SRIOV_NIC.physical_device_mappings)
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent   File "/usr/lib/python2.7/dist-packages/neutron/common/utils.py", line 240, in parse_mappings
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent     "unique") % {'key': key, 'mapping': mapping})
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent ValueError: Key physnet2 in mapping: 'physnet2:enp1s0f1' not unique
  2016-03-17 15:26:48.819 6832 ERROR neutron.plugins.ml2.drivers.mech_sriov.agent.sriov_nic_agent

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1558626/+subscriptions


References