← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1562934] Re: liberty -> mitaka db migrate fails when constraint names are inconsistent

 

Reviewed:  https://review.openstack.org/298402
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9e81843719dab3c66d89adf100bb3e1d5c9cedca
Submitter: Jenkins
Branch:    master

commit 9e81843719dab3c66d89adf100bb3e1d5c9cedca
Author: Morgan Fainberg <morgan.fainberg@xxxxxxxxx>
Date:   Mon Mar 28 10:50:12 2016 -0700

    Correct `role_name` constraint dropping
    
    The `role_name` constraint was not properly dropped in some cases
    because the unique constraint was not consistently named. In all
    cases we must search for the constraint expected, not assume the
    name of the constraint will be consistent (especially from older
    installs that have been moved forward in releases).
    
    This change fixes migration 88, updates 96 (for backport to
    stable/mitaka), and creates migration 101 for anyone who has moved
    beyond the mitaka -> newton placeholders. This is being overly
    cautious, but specifically is to handle the case where someone
    performed the upgrade and manually fixed the migration resulting
    in duplicated constraints in the role_table.
    
    Co-Authored-By: "Matthew Thode" <mthode@xxxxxxxxxx>
    Change-Id: Ie0dc3d2449bace57d3e9323b281a2abd2ad0c983
    closes-bug: #1562934


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1562934

Title:
  liberty -> mitaka db migrate fails when constraint names are
  inconsistent

Status in OpenStack Identity (keystone):
  Fix Released
Status in OpenStack Identity (keystone) mitaka series:
  Fix Released
Status in OpenStack Identity (keystone) newton series:
  In Progress

Bug description:
  specifically 088_domain_specific_roles.py at

      migrate.UniqueConstraint(role_table.c.name,
                               name=_ROLE_NAME_OLD_CONSTRAINT).drop()

  If it was easier to translate into actual sql statements I might be
  able to give more info.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1562934/+subscriptions


References