yahoo-eng-team team mailing list archive

[OpenStack Infra <1559026@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/294512
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c5311439d6526006dd1354e09f2bfb86505d550d
Submitter: Jenkins
Branch:    master

commit c5311439d6526006dd1354e09f2bfb86505d550d
Author: Radoslav Gerganov <rgerganov@xxxxxxxxxx>
Date:   Fri Mar 18 12:56:04 2016 +0200

    The 'record' option of the WebSocketProxy should be string
    
    If proxy service (VNC, spice, serial) is started with the 'record'
    option, an exception is thrown. This is because WebSocketProxy
    expects a file path for the record argument instead of boolean
    value. This patch fixes this by changing 'record' to be string
    option. An empty string means no recording.
    
    Closes-Bug: #1559026
    
    Change-Id: Id6cf7c65191bdaa579f7cdadea43230897436de6


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1559026

Title:
  nova-novncproxy doesn't start when 'record' is specified

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) liberty series:
  New
Status in OpenStack Compute (nova) mitaka series:
  New

Bug description:
  $ /usr/local/bin/nova-novncproxy --record --config-file
  /etc/nova/nova.conf --web /opt/stack/noVNC

  2016-03-18 12:34:01.940 CRITICAL nova [-] AttributeError: 'bool'
  object has no attribute 'startswith'

  2016-03-18 12:34:01.940 TRACE nova Traceback (most recent call last):
  2016-03-18 12:34:01.940 TRACE nova   File "/usr/local/bin/nova-novncproxy", line 10, in <module>
  2016-03-18 12:34:01.940 TRACE nova     sys.exit(main())
  2016-03-18 12:34:01.940 TRACE nova   File "/opt/stack/nova/nova/cmd/novncproxy.py", line 39, in main
  2016-03-18 12:34:01.940 TRACE nova     port=CONF.vnc.novncproxy_port)
  2016-03-18 12:34:01.940 TRACE nova   File "/opt/stack/nova/nova/cmd/baseproxy.py", line 73, in proxy
  2016-03-18 12:34:01.940 TRACE nova     RequestHandlerClass=websocketproxy.NovaProxyRequestHandler
  2016-03-18 12:34:01.940 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/websockify/websocketproxy.py", line 265, in __init__
  2016-03-18 12:34:01.940 TRACE nova     websocket.WebSocketServer.__init__(self, RequestHandlerClass, *args, **kwargs)
  2016-03-18 12:34:01.940 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/websockify/websocket.py", line 647, in __init__
  2016-03-18 12:34:01.940 TRACE nova     self.record = os.path.abspath(record)
  2016-03-18 12:34:01.940 TRACE nova   File "/usr/lib/python2.7/posixpath.py", line 367, in abspath
  2016-03-18 12:34:01.940 TRACE nova     if not isabs(path):
  2016-03-18 12:34:01.940 TRACE nova   File "/usr/lib/python2.7/posixpath.py", line 61, in isabs
  2016-03-18 12:34:01.940 TRACE nova     return s.startswith('/')
  2016-03-18 12:34:01.940 TRACE nova AttributeError: 'bool' object has no attribute 'startswith'
  2016-03-18 12:34:01.940 TRACE nova 

  
  The 'record' argument should be string, not boolean.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1559026/+subscriptions