← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1562834] Re: There are some trivial errors in doc/tutorials/plugin.rst

 

Reviewed:  https://review.openstack.org/299468
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6a880bd0c16ecdff7ae9917fb7abb4535b09cd78
Submitter: Jenkins
Branch:    master

commit 6a880bd0c16ecdff7ae9917fb7abb4535b09cd78
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Wed Mar 30 23:13:18 2016 +0800

    Fix some trivial errors in plugin.rst
    
    1. ADD_JS_FILES should be mentioned
    2. scss files can not be discovered automatically
    3. remove incorrect scss exmaple codes
    
    Change-Id: Id543673a925eedb824b8222982e9ba35110fc44a
    Closes-Bug: #1562834


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1562834

Title:
  There are some trivial errors in doc/tutorials/plugin.rst

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  1. ADD_JS_FILES is not menthoned but only ADD_SCSS_FILES
  http://docs.openstack.org/developer/horizon/tutorials/plugin.html#file-structure

  
  http://docs.openstack.org/developer/horizon/tutorials/plugin.html#mypanel-scss
  2. static files under static/ could be discovery automatically
  3. "div" should not in scss file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1562834/+subscriptions


References