yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #48979
[Bug 1477292] Re: launch instance step scss references ng controller
This is no longer a bug following the Launch Instance cleanup
** Changed in: horizon
Status: New => Invalid
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1477292
Title:
launch instance step scss references ng controller
Status in OpenStack Dashboard (Horizon):
Invalid
Bug description:
For example, security-groups.scss contains a selector:
[ng-controller="LaunchInstanceSecurityGroupsController as ctrl"] {
This is very fragile and will break styling if the step is refactored
to become a directive, or if the controller name is changed, or if the
angular template for that page is overridden.
Instead, use a class in the HTML template such as
class="security-groups-controlller"
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1477292/+subscriptions
References