← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1016633] Re: Bad performance problem with nova.virt.firewall

 

@Hans Lindgren: Thanks for the feedback. This bug report is really old
and I doubt that the current "medium" importance is still valid. I
close this as fix released, thanks for you patch.

@David Kranz (+ other stakeholders): Please double-check if the 
issue is fixed from your perspective. Use the current master (Newton) 
code for that. If it is not fixed, please reopen and provide some
information how you tested this.

** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1016633

Title:
  Bad performance problem with nova.virt.firewall

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  I was trying to figure out why creating 1,2,4 servers in parallel on an 8-core machine did not show any speedup. I found a
  problem shown in this log snippet with 4 servers. The pair of calls producing the debug messages are separated only by
  a single call. 

      def prepare_instance_filter(self, instance, network_info):
          # make sure this is legacy nw_info
          network_info = self._handle_network_info_model(network_info)

          self.instances[instance['id']] = instance
          self.network_infos[instance['id']] = network_info
          self.add_filters_for_instance(instance)
          LOG.debug(_('Filters added to instance'), instance=instance)
          self.refresh_provider_fw_rules()
          LOG.debug(_('Provider Firewall Rules refreshed'), instance=instance)
          self.iptables.apply()

  Note the interleaving of the last two calls in this log snippet and
  how long they take:

  
  Jun 22 10:52:09 xg06eth0 2012-06-22 10:52:09 DEBUG nova.virt.firewall [req-14689766-cc17-4d8d-85bb-c4c19a2fc88d demo demo] [instance: 4c5a43af-04fd-4aa0-818e-8e0c5384b279] Filters added to instance from (pid=15704) prepare_instance_filter /opt/stack/nova/nova/virt/firewall.py:151

  Jun 22 10:52:10 xg06eth0 2012-06-22 10:52:10 DEBUG
  nova.virt.firewall [req-14689766-cc17-4d8d-85bb-c4c19a2fc88d demo
  demo] [instance: 4c5a43af-04fd-4aa0-818e-8e0c5384b279] Provider
  Firewall Rules refreshed from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:153

  Jun 22 10:52:18 xg06eth0 2012-06-22 10:52:18 DEBUG
  nova.virt.firewall [req-c9ed42e0-1eed-418a-ba37-132bcc26735c demo
  demo] [instance: df15e7d6-657e-4fd7-a4eb-6aab1bd63d5b] Filters added
  to instance from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:151

  Jun 22 10:52:19 xg06eth0 2012-06-22 10:52:19 DEBUG
  nova.virt.firewall [req-c9ed42e0-1eed-418a-ba37-132bcc26735c demo
  demo] [instance: df15e7d6-657e-4fd7-a4eb-6aab1bd63d5b] Provider
  Firewall Rules refreshed from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:153

  Jun 22 10:52:19 xg06eth0 2012-06-22 10:52:19 DEBUG
  nova.virt.firewall [req-2daf4cb8-73c5-487a-9bf6-bea08125b461 demo
  demo] [instance: 765212a6-cc23-4d5a-b252-5fa6b5f8331e] Filters added
  to instance from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:151

  Jun 22 10:52:25 xg06eth0 2012-06-22 10:52:25 DEBUG
  nova.virt.firewall [req-5618e93e-3af1-4c65-b826-9d38850a215d demo
  demo] [instance: fa6423ac-82b8-419b-a077-f2d44d081771] Filters added
  to instance from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:151

  Jun 22 10:52:38 xg06eth0 2012-06-22 10:52:38 DEBUG
  nova.virt.firewall [req-2daf4cb8-73c5-487a-9bf6-bea08125b461 demo
  demo] [instance: 765212a6-cc23-4d5a-b252-5fa6b5f8331e] Provider
  Firewall Rules refreshed from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:153

  Jun 22 10:52:52 xg06eth0 2012-06-22 10:52:52 DEBUG
  nova.virt.firewall [req-5618e93e-3af1-4c65-b826-9d38850a215d demo
  demo] [instance: fa6423ac-82b8-419b-a077-f2d44d081771] Provider
  Firewall Rules refreshed from (pid=15704) prepare_instance_filter
  /opt/stack/nova/nova/virt/firewall.py:153

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1016633/+subscriptions