yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #49118
[Bug 1564820] Re: DSCP rules won't get updated on ports
Reviewed: https://review.openstack.org/300635
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6b6c0421bb6658b475bddb68f766b395945e1b46
Submitter: Jenkins
Branch: master
commit 6b6c0421bb6658b475bddb68f766b395945e1b46
Author: Nate Johnston <nate_johnston@xxxxxxxxxxxxxxxxx>
Date: Fri Apr 1 15:53:20 2016 -0400
QoS DSCP use mod_flow instead of mod_flows
In the implementation of DSCP QoS rule, the QosOVSAgentDriver uses the
wrong method to modify br-int flows. It uses br_int.mod_flows() whilst
it should use br_int.mod_flow().
This patch fixes this and also adds verification of the updates of DSCP,
as we have for bandwidth here to trigger that code path and avoid
regressions.
Change-Id: I685ac373701ff8407fd7fbf649e17a2f7dfc0008
Closes-Bug: #1564820
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1564820
Title:
DSCP rules won't get updated on ports
Status in neutron:
Fix Released
Bug description:
When updating DSCP rules, ovs agent will fail
Reason
======
In the implementation of DSCP QoS rule, the QosOVSAgentDriver uses the wrong method to modify br-int flows. It uses br_int.mod_flows() whilst it should use br_int.mod_flow():
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py#L89
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1564820/+subscriptions
References