yahoo-eng-team team mailing list archive

[OpenStack Infra <1567023@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/302421
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1e334e8fe1db43585154d525c0c1599ac3e2a329
Submitter: Jenkins
Branch:    master

commit 1e334e8fe1db43585154d525c0c1599ac3e2a329
Author: Assaf Muller <amuller@xxxxxxxxxx>
Date:   Wed Apr 6 14:31:24 2016 -0400

    Fix keepalived functional tests
    
    Running the tests locally I'm seeing:
    http://paste.openstack.org/show/493222/
    
    The issue in all three tests is that the keepalived manager
    process spawns asynchronously (sudo -> root_helper -> keepalived).
    
    For the 'spawns' test, it was asserting that process.alive was
    True when it should have used wait_until_true.
    
    For the respawns* tests, the test grabs process.pid before the process
    has necessarily spawned. Moving process.pid to after the wait_until_true(
    process.active) loop guarantees that pid will return keepalived's
    process. Otherwise the 'pid' variable will be None, then when we
    use utils.execute we try to kill the 'None' pid, and that doesn't seem
    to work.
    
    Change-Id: Ie77d406eaaf7f77edd4f598947999be4adf3d249
    Closes-Bug: #1567023


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1567023

Title:
  test_keepalived_respawns* functional tests raceful

Status in neutron:
  Fix Released

Bug description:
  Running just KeepalivedManagerTestCase locally I see the following
  three tests fail frequently:

  test_keepalived_spawn
  test_keepalived_respawns
  test_keepalived_respawn_with_unexpected_exit

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1567023/+subscriptions