← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1522067] Re: NG Launch Instance: load script sometimes doesn't show in text area

 

Reviewed:  https://review.openstack.org/258477
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d2692ef801045070858f5e6ea7f3e95a468cb5c4
Submitter: Jenkins
Branch:    master

commit d2692ef801045070858f5e6ea7f3e95a468cb5c4
Author: Itxaka <iserrano@xxxxxxxxxx>
Date:   Wed Dec 16 13:53:17 2015 +0100

    NG launch instance: Clear fileInput value on text change
    
    The onchange event occurs when a control loses the input
    focus and its value has been modified since gaining focus.
    This attribute applies to the following elements:
    INPUT, SELECT, and TEXTAREA.
    http://www.w3.org/TR/html4/interact/scripts.html#adef-onchange
    
    This affected uploading a script and modifying it, as it would
    not allow to reupload it again.
    This patch cleans the fileInput.val() on textInput change so
    a user can upload a script, modify it, and reupload the same
    script again if he wants to start from a clean scratch again
    
    Change-Id: Ie2d29de4ebcdea07f7e3e2ce6c7094c1d2fe5e10
    Closes-Bug: #1522067


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1522067

Title:
  NG Launch Instance: load script sometimes doesn't show in text area

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Using the Angular Launch Instance, when in the Configuration step,
  sometimes the script content is not loaded into the "Customization
  Script" textarea.

  To reproduce:

  1. Enter some text "123456".
  2. Load a script from file. The content should appear in textarea.
  3. Select all of the content in the textarea and enter "123456".
  4. Now, try loading a different script from file again. The content of the script doesn't show up in the textarea.

  Testing in browsers: Safari and Chrome

  Works fine in Firefox

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1522067/+subscriptions


References