yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #49221
[Bug 1567855] Re: auto allocate topology plugin subscribe calls not safe for tests
Reviewed: https://review.openstack.org/303333
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a56bbac059f7fe434a8b92370f1363a17e700e74
Submitter: Jenkins
Branch: master
commit a56bbac059f7fe434a8b92370f1363a17e700e74
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date: Wed Apr 6 10:06:32 2016 -0700
Make auto allocate plugin safe for unit/func tests
The registry.subscribe calls cannot happen at import time because
a module is imported only once for a test runner, but the callback
manager is wiped out for each test.
This changes the subscribe calls to happen on object construction
instead of at import time.
Change-Id: I1f0cc65000ea613dda58dea3a1a85621c26cda9a
Closes-Bug: #1567855
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1567855
Title:
auto allocate topology plugin subscribe calls not safe for tests
Status in neutron:
Fix Released
Bug description:
The auto allocate topology DB mixin registers its callback mechanisms
with the registry on import time. While this is fine in normal
deployments, it does not work correctly in the functional/unit tests
because each test gets a new callback manager. So a functional test
that runs with the auto topology plugin will fail if another test runs
in front of it that eats the subscribed callbacks.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1567855/+subscriptions
References