yahoo-eng-team team mailing list archive

[OpenStack Infra <1520633@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/239054
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9989a75384aeb6c6b398e7caf8dee140c6bf0423
Submitter: Jenkins
Branch:    master

commit 9989a75384aeb6c6b398e7caf8dee140c6bf0423
Author: Artom Lifshitz <alifshit@xxxxxxxxxx>
Date:   Fri Oct 23 18:09:04 2015 +0000

    Fix max concurrent builds's unlimited semaphore
    
    When booting an instance with the config paramter
    max_concurrent_builds set to 0, a TypeError is logged in the compute
    log. This doesn't prevent the instance from booting, but could be
    confusing to someone debugging a different issue. This patch fixes
    this issue by fixing the method signature of the __exit__ method of
    compute utils's UnlimitedSemaphore. UnlimitedSemaphore was bypassed
    entirely in unit tests because the default value for
    max_concurrent_builds is 10.
    
    Closes-bug: 1520633
    Change-Id: I15825eb3fb1bccb12f4a9148809495ce3e83e3c8


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1520633

Title:
  Exception in compute log when booting an instance with
  max_concurrent_builds=0

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The following exception appears in Nova's compute log when booting an
  instance with the config parameter max_concurrent_builds set to 0:

  Traceback (most recent call last):
    File "/usr/local/lib/python2.7/dist-packages/eventlet/queue.py", line 117, in switch
      self.greenlet.switch(value)
    File "/opt/stack/nova/nova/utils.py", line 1201, in context_wrapper
      func(*args, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 271, in inner
      return f(*args, **kwargs)
    File "/opt/stack/nova/nova/compute/manager.py", line 1850, in _locked_do_build_and_run_instance
      self._do_build_and_run_instance(*args, **kwargs)
  TypeError: __exit__() takes exactly 1 argument (4 given)

  The instance boots fine, but it would be better to not have this
  exception in the logs, as it could confuse someone debugging an
  unrelated issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1520633/+subscriptions