← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1567231] Re: glance using get_transport and not the correct get_notifications_transport for oslo.messaging configuration

 

Reviewed:  https://review.openstack.org/300313
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=a31b963c1bc6f52cbfd71e29dfa54509b5deadcc
Submitter: Jenkins
Branch:    master

commit a31b963c1bc6f52cbfd71e29dfa54509b5deadcc
Author: Juan Antonio Osorio Robles <jaosorior@xxxxxxxxxx>
Date:   Fri Apr 1 08:51:54 2016 +0300

    Use messaging notifications transport instead of default
    
    The usage of oslo_messaging.get_transport is not meant for
    notifications; And oslo_messaging.get_notification_transport is
    favored for those means. So this change introduces the usage of that
    function.
    
    If the settings for the notifications are not set with the
    configuration that's under the oslo_messaging_notifications group,
    this will fall back to the old settings which are under the DEFAULT
    group; just like this used to work.
    
    Closes-Bug: #1567231
    
    Change-Id: I137d0f98533d8121334e8538d321fb6c7495f35f


** Changed in: glance
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1567231

Title:
  glance using get_transport and not the correct
  get_notifications_transport for oslo.messaging configuration

Status in Glance:
  Fix Released

Bug description:
  This applies mostly for code-correctness. configuring notifications
  using the standard options in the default group is meant to be
  deprecated in favor of options in the group
  oslo_messaging_notifications[1]. So basically what this enables is to
  be able to use that group to configure the notifications. As a
  fallback, the default group will still work though.

  Usually this is useful to be able to configure a separate vhost and
  user for notifications and for RPCs; But glance doesn't really have
  this problem as it's using oslo.messaging only for notifications.

  [1]
  http://docs.openstack.org/developer/oslo.messaging/opts.html#oslo_messaging_notifications.transport_url

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1567231/+subscriptions


References