yahoo-eng-team team mailing list archive

[OpenStack Infra <1496873@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/224764
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ea42c340c99b92e4710fbd5b31ddb884d590851b
Submitter: Jenkins
Branch:    master

commit ea42c340c99b92e4710fbd5b31ddb884d590851b
Author: Roman Podoliaka <rpodolyaka@xxxxxxxxxxxx>
Date:   Thu Sep 17 13:17:55 2015 +0300

    libvirt: delete the last file link in _supports_direct_io()
    
    In _supports_direct_io() check, if open() with O_DIRECT succeeds, but
    write() of a 512-bytes aligned block fails, the file descriptor
    remains opened after unlink(), which means the temporary file will
    persist until nova-compute is stopped.
    
    TrivialFix
    
    Closes-Bug: #1496873
    
    Change-Id: I9c1809e35d9641c0d7bfb331de75e6dabf1bdcfe


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1496873

Title:
  nova-compute leaves an open file descriptor after failed check for
  direct IO support

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  On my Kilo environment I noticed that nova-compute has an open file
  descriptor of a deleted file:

  nova-compute 14204 nova   21w   REG              252,0        0
  117440706 /var/lib/nova/instances/.directio.test (deleted)

  According to logs the check if FS supports direct IO failed:

  2015-09-15 22:11:33.171 14204 DEBUG nova.virt.libvirt.driver [req-
  f11861ed-bcd8-46cb-8d0b-b7736cce7f80 59d099e0cc1c44e991a02a68dbbb1815
  5e6f6da2b2d74a108ccdead3b30f0bcf - - -] Path '/var/lib/nova/instances'
  does not support direct I/O: '[Errno 22] Invalid argument'
  _supports_direct_io /usr/lib/python2.7/dist-
  packages/nova/virt/libvirt/driver.py:2588

  Looks like nova-compute doesn't clean up the file descriptors
  properly, which means the file will persist, until nova-compute is
  stopped.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1496873/+subscriptions