yahoo-eng-team team mailing list archive

[Pavel Bondar <pbondar@xxxxxxxxxxxx>]

Public bug reported:

AutomaticAddressRequest is created manually in add_auto_addrs_on_network_ports [1]. But expcected workflow is to use address request factory, that can be overriden by ipam driver to deliver custom AddressRequest classes.
Address request factory generates ip request based on input.

Expected way of preparing address request can be seen in [2]:

  factory = ipam_driver.get_address_request_factory()
  ip_request = factory.get_request(context, port, ip_dict)

Factory method is currently not called for SLAAC allocations, so third
party ipam driver can not deliver custom AddressRequest for this kind of
allocations.

[1] https://github.com/openstack/neutron/blob/2a305c563073a3066aac3f07aab3c895ec2cd2fb/neutron/db/ipam_pluggable_backend.py#L372
[2] https://github.com/openstack/neutron/blob/2a305c563073a3066aac3f07aab3c895ec2cd2fb/neutron/db/ipam_pluggable_backend.py#L80

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: l3-ipam-dhcp

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1570465

Title:
  [Pluggable IPAM] AutomaticAddressRequest is created manually instead
  of using factory

Status in neutron:
  New

Bug description:
  AutomaticAddressRequest is created manually in add_auto_addrs_on_network_ports [1]. But expcected workflow is to use address request factory, that can be overriden by ipam driver to deliver custom AddressRequest classes.
  Address request factory generates ip request based on input.

  Expected way of preparing address request can be seen in [2]:

    factory = ipam_driver.get_address_request_factory()
    ip_request = factory.get_request(context, port, ip_dict)

  Factory method is currently not called for SLAAC allocations, so third
  party ipam driver can not deliver custom AddressRequest for this kind
  of allocations.

  [1] https://github.com/openstack/neutron/blob/2a305c563073a3066aac3f07aab3c895ec2cd2fb/neutron/db/ipam_pluggable_backend.py#L372
  [2] https://github.com/openstack/neutron/blob/2a305c563073a3066aac3f07aab3c895ec2cd2fb/neutron/db/ipam_pluggable_backend.py#L80

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1570465/+subscriptions