← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1570803] Re: complicated wrong logic inside selenium wrapper _execute method

 

Reviewed:  https://review.openstack.org/306325
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=755d07cbdf66b2b01940dc2031692dce07c3e75b
Submitter: Jenkins
Branch:    master

commit 755d07cbdf66b2b01940dc2031692dce07c3e75b
Author: Sergei Chipiga <schipiga@xxxxxxxxxxxx>
Date:   Fri Apr 15 12:35:32 2016 +0300

    Fix longtime tests
    
    The core problem is in usage `while True:` to wait element,
    but implicit_wait delegates its to browser already.
    Just we need to catch StaleElement exception, reload
    chain of element parents and then to execute command again.
    
    Change-Id: I9c94b8adb04489c9675644d1501919af35e5bf99
    Closes-Bug: #1570803


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1570803

Title:
  complicated wrong logic inside selenium wrapper _execute method

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  I found that method _execute inside horizon/tests/webdriver.py has
  complicated and wrong logic, that in race condition leads to long
  tests, for example we have tests with 10 min duration.

  The core problem is that `while True` is used to wait for an element, but `implicit_wait` delegates this to browser already.
  We need just to catch StaleElementRereferenceException, reload the chain of element's parents and then execute a command again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1570803/+subscriptions


References