← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1569942] Re: Network wizard allocation pools breaks Disable Gateway checkbox and field behavior

 

Reviewed:  https://review.openstack.org/263249
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb804ac4ada82c862905a1f24069ee78c6e8fe4e
Submitter: Jenkins
Branch:    master

commit fb804ac4ada82c862905a1f24069ee78c6e8fe4e
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Mon Jan 4 21:02:44 2016 +0800

    Fix workflow bug in "Create Network" dialog
    
    In "Subnet Info" tab, the button "Next" will hide and
    button "Create" will show if checked Disable Gateway.
    Because value of hide_tab is undefined but transformed to
    hide_tab = ['undefined'] in js code.
    
    Remove unused ',' which will introduce empty element in list:
    String(['a', 'b',]).split(,) --> ['a', 'b', '']
    
    Switching field "address_source" should not trigger
    field "gateway_ip" show/disappear.
    
    Closes-Bug: #1487005
    Closes-Bug: #1530729
    Closes-Bug: #1569942
    Change-Id: If9e417e151e11c8ee46ded50ee3ee8108ed777a4


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1569942

Title:
  Network wizard allocation pools breaks Disable Gateway checkbox and
  field behavior

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  I found that 'Disable Gateway' checkbox works weirdly with new
  'Allocate Network address from a pool' feature: when I first change it
  from manual mode to pool mode, Gateway Address field disappears, but
  once I check and uncheck 'Disable Gateway' checkbox field it reappears
  again.

  Moreover, if I check 'Disable Gateway' while in pool mode, then switch
  to manual mode, Gateway Address field reappears even with 'Disable
  Gateway' checkbox checked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1569942/+subscriptions


References