yahoo-eng-team team mailing list archive

[OpenStack Infra <1570392@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/305863
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8a86ba1d014a5e758c0569aaf16cfe92492cc7f1
Submitter: Jenkins
Branch:    master

commit 8a86ba1d014a5e758c0569aaf16cfe92492cc7f1
Author: Ihar Hrachyshka <ihrachys@xxxxxxxxxx>
Date:   Thu Apr 14 15:43:29 2016 +0200

    Support interface drivers that don't support mtu parameter for plug_new
    
    The method signature before Mitaka did not have the mtu= parameter. We
    should continue supporting the old signature, since it can be used in
    out of tree interface drivers. The class is part of public neutron API,
    so we should make an effort to not break out of tree code.
    
    Change-Id: I8e0c07c76fd0b4c55b66c20ebe29cdb7c07d6f27
    Closes-Bug: #1570392


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1570392

Title:
  Interface drivers that don't support mtu= argument for plug_new() are
  broken

Status in neutron:
  Fix Released

Bug description:
  https://review.openstack.org/#/c/283790/ introduced support for mtu=
  argument for interface drivers. Sadly, it also broke out of tree
  interface drivers. We can see it in the following Liberty unit test
  logs when executed with the patch backported:

  http://logs.openstack.org/82/305782/1/check/gate-neutron-
  python27/a6c7e7d/testr_results.html.gz

  ft53.2: neutron.tests.unit.agent.linux.test_interface.TestMidonetInterfaceDriver.test_plug_StringException: Empty attachments:
    pythonlogging:''
    pythonlogging:'neutron.api.extensions'
    stderr
    stdout

  Traceback (most recent call last):
    File "neutron/tests/unit/agent/linux/test_interface.py", line 694, in test_plug
      self.bridge, self.namespace)
    File "neutron/agent/linux/interface.py", line 253, in plug
      bridge, namespace, prefix, mtu)
  TypeError: plug_new() takes at most 8 arguments (9 given)

  We could catch the exception and retry without the parameter.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1570392/+subscriptions