← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1571662] Re: redundant code line in integration tests to logout user

 

Reviewed:  https://review.openstack.org/306686
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=db604ac62ac8cecb817796c12e30663b33d96f2d
Submitter: Jenkins
Branch:    master

commit db604ac62ac8cecb817796c12e30663b33d96f2d
Author: Sergei Chipiga <schipiga@xxxxxxxxxxxx>
Date:   Sat Apr 16 08:53:28 2016 +0300

    Remove redundant line to open login page
    
    Change-Id: I272ee5c205a49f93b8cccde7718ad3ea2193fff6
    Closes-Bug: #1571662


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1571662

Title:
  redundant code line in integration tests to logout user

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  we have redundant code line `return self.go_to_login_page()` in
  method:

      def log_out(self):
          self.topbar.user_dropdown_menu.click_on_logout()
          return self.go_to_login_page()

  Page will be redirected to login page after logout without direct
  navigation. So it's not necessary, moreover  it can create race
  condition due to async execution: on one hand click to logout link, on
  other hand navigation to login page. In some cases we met fallen tests
  due to that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1571662/+subscriptions


References