yahoo-eng-team team mailing list archive

[OpenStack Infra <1568764@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/304067
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=17176d06173133a7e59432fdbd46af30e44c20d3
Submitter: Jenkins
Branch:    master

commit 17176d06173133a7e59432fdbd46af30e44c20d3
Author: Yves-Gwenael Bourhis <yves-gwenael.bourhis@xxxxxxxxxxxxx>
Date:   Mon Apr 11 13:40:44 2016 +0200

    Template loaders defined before local settings
    
    TEMPLATE_LOADERS was defined after loading local_settings.py and was sqashing
    any attempt to customize the template loaders.
    This patch adds CACHED_TEMPLATE_LOADERS, ADD_TEMPLATE_LOADERS and a doc
    defining how to use them in order to ease customization process.
    
    Change-Id: I2544529ee965ef01c6ac4973056801ebee50be6d
    Closes-Bug: #1568764


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1568764

Title:
  impossible to modify template loaders when customizon horizon

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When customizing horizon as per:
  http://docs.openstack.org/developer/horizon/topics/customizing.html#modifying-existing-dashboards-and-panels

  we need to modify TEMPLATE_LOADERS in local settings, usually horizon customizers need:
  https://pypi.python.org/pypi/django-apptemplates/

  To extend original templates with ease

  Since this patch:
  https://review.openstack.org/#/c/281976/

  horizon simply nukes any attempt to modify TEMPLATE_LOADERS because
  they are redifined after loading the local_settings. therefore
  customizing horizon is impossible without doing horizon code
  intrusion.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1568764/+subscriptions