yahoo-eng-team team mailing list archive

[OpenStack Infra <1573652@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/309503
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=5aa52f142e27080fa3e54490d82a718ebd2a6852
Submitter: Jenkins
Branch:    master

commit 5aa52f142e27080fa3e54490d82a718ebd2a6852
Author: Niall Bunting <niall.bunting@xxxxxxx>
Date:   Fri Apr 22 16:32:22 2016 +0000

    Functional test comparing wrong items
    
    A small fix to test a wrong comparison.
    
    Change-Id: Ia70d9ef289ca7f0bf10c3e4199db2de588602c3f
    Closes-bug: 1573652


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1573652

Title:
  Some v2 tests' checks are wrong

Status in Glance:
  Fix Released

Bug description:
  In ./glance/tests/functional/v2/test_images.py

  Tests such as test_download_image_allowed_using_restricted_policy do
  this:

          expected_image = {
              'status': 'queued',
              'name': 'image-1',
              'tags': [],
              'visibility': 'private',
              'self': '/v2/images/%s' % image_id,
              'protected': False,
              'file': '/v2/images/%s/file' % image_id,
              'min_disk': 0,
              'min_ram': 0,
              'schema': '/v2/schemas/image',
          }

          for key, value in six.iteritems(expected_image):
              self.assertEqual(value, value, key)

  It looks like we're checking 'value' against 'value' which doesn't
  seem right.

  This possibly should be: self.assertEqual(value, image[key])

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1573652/+subscriptions