yahoo-eng-team team mailing list archive

[Robin Neatherway <robin@xxxxxxxxxx>]

Public bug reported:


If a MaxRetriesExceeded exception is raised by scheduler_utils.populate_retry then request_spec will be undefined in the exception handler, see: https://git.openstack.org/cgit/openstack/nova/tree/nova/conductor/manager.py#n422

This was introduced by moving the initialization of request_spec inside
the try block in
https://git.openstack.org/cgit/openstack/nova/commit/nova/conductor/manager.py?id=399f3abbf9da6ba9f3ae83650513616b151420cb

Simply moving the initialization of request_spec up one line before the
call to populate_retry should fix the issue.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1575598

Title:
  ComputeTaskManager.build_instances exception handling can fail

Status in OpenStack Compute (nova):
  New

Bug description:
  
  If a MaxRetriesExceeded exception is raised by scheduler_utils.populate_retry then request_spec will be undefined in the exception handler, see: https://git.openstack.org/cgit/openstack/nova/tree/nova/conductor/manager.py#n422

  This was introduced by moving the initialization of request_spec
  inside the try block in
  https://git.openstack.org/cgit/openstack/nova/commit/nova/conductor/manager.py?id=399f3abbf9da6ba9f3ae83650513616b151420cb

  Simply moving the initialization of request_spec up one line before
  the call to populate_retry should fix the issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1575598/+subscriptions