yahoo-eng-team team mailing list archive

[OpenStack Infra <1561550@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/302526
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fdf0bf6f186f056fea6ed5761616c40463a2e269
Submitter: Jenkins
Branch:    master

commit fdf0bf6f186f056fea6ed5761616c40463a2e269
Author: Richard Jones <r1chardj0n3s@xxxxxxxxx>
Date:   Thu Apr 7 14:28:05 2016 +1000

    Fix babel msgids to include tag attributes and entities
    
    The messages for translation were omitting the attributes in
    tags and HTML entities embedded in the translation strings,
    thus they no longer matched the original HTML.
    
    Additionally, HTML entities are mostly (but not always) decoded
    by the browser before angular-gettext sees them, so we have to
    emulate this behaviour in our babel extractor so the message
    ids match.
    
    Change-Id: Ie6ae0776a2c0d7db589b34a9e7676508178a473d
    Closes-Bug: 1561550
    Closes-Bug: 1561738
    Closes-Bug: 1561761


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1561550

Title:
  Untranslated strings found in Launch Instance window

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Project > Instances > Launch Instance > Details

  Strings "Instance Name" and "Count" are not localized in the UI.

  DRF Added: also "Configuration Drive" on the Configuration step is not
  localized.

  According to Motoki-san (amotoki), those strings are not included in
  pot files under the horizon project, despite they are labled with
  "translate" in the directives and should be considered as
  translatable. It could be due to the tool's bug which inserts
  linebreaks, possibly preventing the strings to be extracted.

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow
  /launch-instance/details/details.html#L9

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1561550/+subscriptions