yahoo-eng-team team mailing list archive

[OpenStack Infra <1535779@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/269724
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3b195c0ef657c8ddc8855cf3f17177c6e7db32b5
Submitter: Jenkins
Branch:    master

commit 3b195c0ef657c8ddc8855cf3f17177c6e7db32b5
Author: Matt Borland <matt.borland@xxxxxx>
Date:   Tue Jan 19 08:52:36 2016 -0700

    Removing unnecessary Angular Image files
    
    There seem to be some leftover image files from before the move to app/core.
    
    Change-Id: Ibaa5f278140aa65fc34d5e6274c0e31536f355e2
    Closes-Bug: 1535779


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1535779

Title:
  Unnecessary image module in Angular

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Unless I'm misunderstanding something, it appears that the items in
  the path:

  ./openstack_dashboard/dashboards/project/static/dashboard/project/images/

  are unnecessary/vestigial.  It seems all such image-related features
  should be in:

  ./openstack_dashboard/static/app/core/images/

  The module that is currently in that unused directory specifies:
  "horizon.dashboard.project.images" as its namespace; this shows itself
  to be outdated as "horizon.app.core.images" is the proper namespace.

  There are other items in a similar directory (.../dahsboard/project/)
  that seem equally wrongly placed, but because that includes actual
  used items, there may be more upheaval in moving, whereas there seem
  to be no image-based features using "horizon.dashboard.project.images"
  ( find openstack_dashboard/ -name "*.js" -exec grep -l
  horizon.dashboard.project.images {} \; ).

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1535779/+subscriptions