yahoo-eng-team team mailing list archive

["vikram.choudhary" <vikram.choudhary@xxxxxxxxxx>]

Public bug reported:

Currently, there is inconsistent alias names for the lib imports which
makes the code really difficult to read. Constansts from neutron-lib is
being imported as consts / n_consts / lib_consts and constants from
neutron is also being imported as consts / n_consts. This is really
frustrating & confusing.

IMO, uniform alias will help to increase code readability and
maintainability. FYI, we have already pointed out this while reviewing
https://review.openstack.org/#/c/299017/ and felt the need of uniform
alias (For details one can refer to the PS16 comment discussion)

I would suggest we can use a prefix 'n_' while importing from neutron
and 'lib_' for neutron-lib.

** Affects: neutron
     Importance: Undecided
     Assignee: vikram.choudhary (vikschw)
         Status: New


** Tags: low-hanging-fruit

** Changed in: neutron
     Assignee: (unassigned) => vikram.choudhary (vikschw)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1579496

Title:
  inconsistent alias names for the lib imports

Status in neutron:
  New

Bug description:
  Currently, there is inconsistent alias names for the lib imports which
  makes the code really difficult to read. Constansts from neutron-lib
  is being imported as consts / n_consts / lib_consts and constants from
  neutron is also being imported as consts / n_consts. This is really
  frustrating & confusing.

  IMO, uniform alias will help to increase code readability and
  maintainability. FYI, we have already pointed out this while reviewing
  https://review.openstack.org/#/c/299017/ and felt the need of uniform
  alias (For details one can refer to the PS16 comment discussion)

  I would suggest we can use a prefix 'n_' while importing from neutron
  and 'lib_' for neutron-lib.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1579496/+subscriptions