yahoo-eng-team team mailing list archive

[OpenStack Infra <1578978@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/294289
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f8cb496735a5c8e38f1189be9fdfc284ff70c753
Submitter: Jenkins
Branch:    master

commit f8cb496735a5c8e38f1189be9fdfc284ff70c753
Author: Ryan Peters <rjpeter2@xxxxxxxxx>
Date:   Thu Mar 17 16:14:44 2016 -0500

    Add semantic markup to Project Overview page
    
    Add a limit-summary class to the graphs on the overview page
    and fix the logic of making the rows.
    
    Change-Id: I396724ec5af874021fbfd673e7c49c5fec83245f
    Closes-Bug: #1578978
    Closes-Bug: #1579164


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1578978

Title:
  Limit summary view on project/overview page is broken when amount of
  charts is changed

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Commit [1] introduced bug of wrong compilation of html tags in [2] template.
  It improperly handles chart elements when their amount does not satisfy criterion "(amount-1) % 2 = 0". "Bug" is in not closed "div" element that leads to improper interpretation of elements on page.
  Also, this template always shows 6 elements on each row and one more on the new one. This template should not split charts by rows explicitly. It fits page nicely without it.

  For the moment it looks as 2 rows aligned for left on wide screen.

  [1] https://github.com/openstack/horizon/commit/3a2564e3
  [2] https://github.com/openstack/horizon/blob/3a2564e3/horizon/templates/horizon/common/_limit_summary.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1578978/+subscriptions