← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1367229] Re: securitygroups_rpc is_firewall_enabled should return False if it is not a valid driver combination

 

[Expired for neutron because there has been no activity for 60 days.]

** Changed in: neutron
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1367229

Title:
  securitygroups_rpc is_firewall_enabled should return False if it is
  not a valid driver combination

Status in neutron:
  Expired

Bug description:
  In neutron.agent.securitygroups_rpc, the method is_firewall_enabled,
  there is the code:

  def is_firewall_enabled():
      if not _is_valid_driver_combination():
      LOG.warn(_("Driver configuration doesn't match with "
                             "enable_security_group"))

  return cfg.CONF.SECURITYGROUP.enable_security_group

  The function should return False if not _is_valid_driver_combination. Otherwise, it could return True in a case it shouldn't:
  cfg.CONF.SECURITYGROUP.firewall_driver = 'neutron.agent.firewall.NoopFirewallDriver'
  cfg.CONF.SECURITYGROUP.enable_security_group = True

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1367229/+subscriptions


References