← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1496197] Re: notify_decorator bad getattr default value

 

Reviewed:  https://review.openstack.org/223890
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f8faf00fb8caa9cf68c487c322162387cb8b4787
Submitter: Jenkins
Branch:    master

commit f8faf00fb8caa9cf68c487c322162387cb8b4787
Author: Andrei V. Ostapenko <aostapenko@xxxxxxxxxxxx>
Date:   Tue Sep 15 12:25:20 2015 -0500

    Fixes bug with notify_decorator bad getattr default value
    
    getattr tries to get method from notifier by its name in config.
    If it fails, string 'info' is returned and called. This patch
    changes default value from string 'info' to method notifier.info
    
    Closes-bug: #1496197
    Change-Id: Id005de79980db3c8ea7256b360a2b2c47bfdace7


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1496197

Title:
  notify_decorator bad getattr default value

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  branch: master
  In nova/notifications.py:

  91        method = getattr(notifier, CONF.default_notification_level.lower(),
  92                                         'info')
  93        method(ctxt, name, body)

  getattr tries to get method from notifier by its name in config. If it
  fails string 'info' is returned and then called

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1496197/+subscriptions


References