yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #50755
[Bug 1491414] Re: LibvirtConfigObject.to_xml() should not log the xml str - leave that to the caller
Reviewed: https://review.openstack.org/224216
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0cd0c1d414e5dceb8f75c5d62426c9d9a5e572f3
Submitter: Jenkins
Branch: master
commit 0cd0c1d414e5dceb8f75c5d62426c9d9a5e572f3
Author: Mark Doffman <mjdoffma@xxxxxxxxxx>
Date: Tue Sep 8 13:40:01 2015 -0500
Move logging outside of LibvirtConfigObject.to_xml
Logging the xml in LibvirtConfigObject doesn't provide
much context. Instead remove the logging from there and
move it to the caller where neccessary.
Log the instance when doing cpu comparison to add context
to the log messages.
Closes-Bug: #1491414
Change-Id: Ie7b9b41de40f10820a2b9e04198464cd2da46e8c
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1491414
Title:
LibvirtConfigObject.to_xml() should not log the xml str - leave that
to the caller
Status in OpenStack Compute (nova):
Fix Released
Bug description:
There are a lot of places where LibvirtConfigObject.to_xml() is called
and then the results are logged in context, like in the libvirt driver
code:
http://logs.openstack.org/55/218355/5/check/gate-tempest-dsvm-neutron-
full/4dce003/logs/screen-n-cpu.txt.gz#_2015-09-01_19_07_16_539
It would actually be nicer to log those in the context of the instance
uuid we're working on, so we get the instance highlighting in the logs
for debugging.
So I think we should remove the LOG.debug call here:
http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/config.py#n82
And for any time that we do really want that xml logged, we can do it
in the calling code where we will usually also have the instance uuid
in context and can log that also.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1491414/+subscriptions
References