← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1580790] Re: Metadata display widget should use case insensitive matching

 

Reviewed:  https://review.openstack.org/315295
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=802ec1f77a2c4aa40804d2f1e46cdc28a757f6d6
Submitter: Jenkins
Branch:    master

commit 802ec1f77a2c4aa40804d2f1e46cdc28a757f6d6
Author: Travis Tripp <travis.tripp@xxxxxxx>
Date:   Wed May 11 18:06:27 2016 -0600

    Change Metadata Display widget to case insensitive
    
    The metadata-display should match properties using case insensitive.
    I've found that if you pass in extra metadata properties to
    Glance v1 at create time, it takes all the properties and stores
    them as lower case. So when you create an image with metadata of
    FOO=BAR, it will store as foo=bar.
    
    There are some properties "CIM_PASD_InstructionSet" that when
    create at the same time as creating the image get changed to
    cim_pasd_instructionset". When this gets subsequently retrieved
    from Glance and displayed in the metadata-display widget,
    it doesn't recognize them and won't show them.
    
    To test, you need: https://review.openstack.org/#/c/236042/
    
    Create an Image using the CIM Instruction Set metadata.
    
    Go to image row and expand. You won't see the metadata.
    
    Apply this patch git review -x 315295
    
    Then do the same steps.  You'll see the metadata displayed:
    
    http://imgur.com/eMfLd9H
    
    Change-Id: I5127283e90505f3580af6afea3eb992a91b8dfc8
    Closes-Bug: 1580790


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1580790

Title:
  Metadata display widget should use case insensitive matching

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The metadata-display should match properties using case insensitive.
  I've found that if you pass in extra metadata properties to Glance v1
  at create time, it takes all the properties and stores them as lower
  case. So when you create an image with metadata of FOO=BAR, it will
  store as foo=bar.

  Maybe when we move off to v2 Glance that won't be a problem?

  There are some properties "CIM_PASD_InstructionSet" that when created
  at the same time as creating the image get changed to
  cim_pasd_instructionset". When this gets subsequently retrieved from
  Glance and displayed in the metadata-display widget, it doesn't
  recognize them and won't show them.

  See:

  https://review.openstack.org/#/c/236042/

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/glance.py#L189-L190

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1580790/+subscriptions


References